winpki: prevent CRL common names from overflowing#57867
Merged
Conversation
zmb3
added
the
no-changelog
zmb3
force-pushed
the
zmb3/crl-cn-limit
branch
from
93f1d93 to
ac3b28b
Compare
Joerger
approved these changes
Aug 13, 2025
zmb3
force-pushed
the
zmb3/crl-cn-limit
branch
2 times, most recently
from
129197a to
4554562
Compare
The addition of the issuer SKID to the CN for our CRLS has caused long clusters to exceed the limit of how long a CN can be. For database access, we rely on the user to run certutil commands to publish the CRL. While we expect the limit to be 64 characters, we observe that certutil starts truncating the CN as soon as it exceeds 51 characters (which causes it to get imported in a different location from what the certificate references).
zmb3
force-pushed
the
zmb3/crl-cn-limit
branch
from
4554562 to
c2d8052
Compare
r0mant
approved these changes
Aug 14, 2025
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
Contributor
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of the issuer SKID to the CN for our CRLS has caused long clusters to exceed the limit of how long a CN can be.
For database access, we rely on the user to run certutil commands to publish the CRL. While we expect the limit to be 64 characters, we observe that certutil starts truncating the CN as soon as it exceeds 51 characters (which causes it to get imported in a different location from what the certificate references).
Note: no changelog because this will land in the same release as #57822 and one changelog entry is enough to cover both fixes.