Merged
Conversation
nklaassen
reviewed
Aug 12, 2025
In #55429 we added an empty certificate revocation list to the TLS keypairs in the certificate_authority backend resource. The intent was that the CRL would be signed by the keypair it is assocaited with, but the code mistakenly used a function that would find _any_ suitable keypair, which could create CRLS signed by the wrong key. This commit corrects both the initial CRL generation as well as any existing CRLs that have invalid signatures.
Collaborator
Author
|
I manually validated this by putting the CRL from a different CA from a different Teleport cluster in my backend and restarting auth. On the first restart, it identified the one invalid CRL and regenerated it. |
nklaassen
approved these changes
Aug 12, 2025
greedy52
approved these changes
Aug 12, 2025
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
In clusters with multiple active signers (like those using HSMs or KMS for private keys), the only safe way to get a CRL is to use the one that's already present in the certificate_authority resource. Generating a CRL with GenerateCertAuthorityCRL will give you a valid CRL, but you have no control over which certificate signs it, which is likely to cause revocation failures later on.
In most cases, we're looking up an existing CRL, not generating one.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #55429 we added an empty certificate revocation list to the TLS keypairs in the certificate_authority backend resource.
The intent was that the CRL would be signed by the keypair it is assocaited with, but the code mistakenly used a function that would find any suitable keypair, which could create CRLS signed by the wrong key.
This commit corrects both the initial CRL generation as well as any existing CRLs that have invalid signatures.
Changelog: fixed an issue that could cause revocation checks to fail in Windows environments.