[v17] [tctl/top] Add raw metrics view#57634
Merged
okraport merged 1 commit intobranch/v17from Aug 7, 2025
Merged
Conversation
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
okraport
requested review from
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
rosstimothy
reviewed
Aug 7, 2025
rosstimothy
approved these changes
Aug 7, 2025
creack
approved these changes
Aug 7, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #57260 to branch/v17
changelog: tctl top can now display raw prometheus metrics