Merged
Conversation
okraport
requested review from
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
Contributor
Author
|
This is currently how this looks like. |
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. Closes: #56944 changelog: tctl top can now display raw prometheus metrics
okraport
force-pushed
the
okraport/tctl-top-raw-metrics
branch
from
89e2c07 to
eb67c78
Compare
rosstimothy
reviewed
Jul 29, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Nice! Looks good to me overall, just a few style related questions and comments.
rosstimothy
approved these changes
Jul 29, 2025
Contributor
Author
|
@creack @greedy52 @fspmarshall Please take a look if possible, thanks! |
fspmarshall
approved these changes
Aug 6, 2025
creack
approved these changes
Aug 6, 2025
Contributor
okraport
added a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
okraport
added a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
okraport
added a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
This was referenced Aug 7, 2025
okraport
added a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
okraport
added a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
This commit adds a new tab to the `tctl top` utility which renders prometheus metrics as a list which supports live updates and filtering. It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy. Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report. Keybinds are now stored as part of the model and used directly for handling KeyMsg events. Note that `list.Model` does not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count. changelog: tctl top can now display raw prometheus metrics * apply review suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new tab to the
tctl toputility which renders prometheus metrics as a list which supports live updates and filtering.It makes use of the bubbles/list charm which supports fuzzy searching via github.com/sahilm/fuzzy.
Refactores the main model to split the refresh tick into seperate tea commands to allow tapping the raw metrics concurrently to generating the report.
Keybinds are now stored as part of the model and used directly for handling KeyMsg events.
Note that
list.Modeldoes not support variable height list item entries and for pagination purposes this value needs to be fixed, for this reason histogram metrics will only render sum and count.Closes: #56944
changelog: tctl top can now display raw prometheus metrics