[v17] [tctl] Add support for debug sock endpoint with fallback in top#57027
Merged
okraport merged 1 commit intobranch/v17from Jul 22, 2025
Merged
[v17] [tctl] Add support for debug sock endpoint with fallback in top#57027okraport merged 1 commit intobranch/v17from
okraport merged 1 commit intobranch/v17from
Conversation
* [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
github-actions
Bot
added
backport
documentation
size/md
tctl
Contributor
|
Amplify deployment status
|
rosstimothy
approved these changes
Jul 22, 2025
marcoandredinis
approved these changes
Jul 22, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from espadolini
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #56886 to branch/v17
changelog: tctl top now supports the local unix sock debug endpoint.