[tctl] Add support for debug sock endpoint with fallback in top#56886
Merged
[tctl] Add support for debug sock endpoint with fallback in top#56886
Conversation
Contributor
|
Amplify deployment status
|
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
c824819 to
495b4d2
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
495b4d2 to
0cf5dd9
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
0cf5dd9 to
8945b1f
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
8945b1f to
d9d6467
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
d9d6467 to
5d1135d
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
5d1135d to
d7bebe9
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
d7bebe9 to
9b55e15
Compare
okraport
force-pushed
the
okraport/tctl-top-metrics-fallback
branch
from
9b55e15 to
14e3546
Compare
rosstimothy
reviewed
Jul 17, 2025
okraport
commented
Jul 18, 2025
rosstimothy
reviewed
Jul 18, 2025
espadolini
approved these changes
Jul 21, 2025
rosstimothy
approved these changes
Jul 21, 2025
public-teleport-github-review-bot
Bot
removed request for
juliaogris,
mmcallister,
ptgott,
r0mant and
zmb3
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
* [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
Contributor
okraport
added a commit
that referenced
this pull request
Jul 22, 2025
* [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
okraport
added a commit
that referenced
this pull request
Jul 22, 2025
* [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
okraport
added a commit
that referenced
this pull request
Jul 22, 2025
* [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
…) (#57026) * [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
…) (#57027) * [tctl] Add support for debug sock endpoint with fallback in top With this change `tctl top` will now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr. If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior. The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips. Closes: #56673 changelog: `tctl top` now supports the local unix sock debug endpoint. * refactor: Simplify top address behaviour based on PR feedback * Refactor top to reuse debug client for metrics. * fix linting issues * Update docs to match support for unix sockets * Fix imports * refactor debug service * clean up error handling in top command * Add footer display for addr * Docs for diag/client * update docs and add addr parser tests * More docs fixes * Fix linting after rebase * Better godocs, more URL test cases, fixed user facing errors * Fix err trace wrapping semantics --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change
tctl topwill now attempt to connect to the local socket debug endpoint before defaulting to the default diag addr.If the user specifies the endpoint explicitly then the command will always attempt the given address regardless of success. This matches previous behavior.
The implementation is not concurrent as only two options exist, both of which are local and not expected to have long round trips.
Example error when failing to connect to any endpoints:
Closes: #56673
changelog: tctl top now supports the local unix sock debug endpoint.