[v18] feat: Bot instance sorting (web)#56696
Merged
nicholasmarais1158 merged 8 commits intobranch/v18from Jul 15, 2025
Merged
Conversation
* feat: Add bot instance cache * Finalise cache implementation and add tests * Appease the linter * Return early in paging logic * Fix import ordering/grouping * Fix test cache setup * Revert BotCache rename * Clean-up commented code * Revert imports order change * Refactor to use generic getter and lister # Conflicts: # lib/auth/authclient/api.go # lib/cache/cache.go # lib/cache/cache_test.go # lib/cache/collections.go
* feat: Add bot instance cache * Finalise cache implementation and add tests * Appease the linter * Return early in paging logic * Fix import ordering/grouping * Fix test cache setup * Revert BotCache rename * Clean-up commented code * Revert imports order change * Refactor to use generic getter and lister * feat(web): Add bot instance sorting * Fix lint and tests * Use `types.SortBy` * Fix races in tests * Handle unsupported upstream sorting * Lint fix * Add unhealthy cache UI test * Use `history.replace` for paging, search and sort * Refactor parsing and formatting of SortType * Return unimplemented error on upstream sort * Tidy up * Keep legacy default sort * Move unsupported sort error to upstream RPC * Add unauthorised error test * Increase `EventuallyWithT` times * Update error messages # Conflicts: # web/packages/teleport/src/BotInstances/List/BotInstancesList.tsx
ravicious
approved these changes
Jul 11, 2025
strideynet
approved these changes
Jul 14, 2025
public-teleport-github-review-bot
bot
removed request for
fspmarshall and
rudream
Base automatically changed from
nicholasmarais1158/backport-55807-branch/v18
to
branch/v18
July 14, 2025 19:41
…158/backport-56024-branch/v18 # Conflicts: # lib/auth/authclient/api.go # lib/auth/machineid/machineidv1/bot_instance_service.go # lib/cache/bot_instance.go # lib/cache/bot_instance_test.go
nicholasmarais1158
deleted the
nicholasmarais1158/backport-56024-branch/v18
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #56024 and #56136 to branch/v18
Depends on: #56163
Updates: #47342
Changelog: Bot instances are now sortable by latest heartbeat time in the web UI