[v18] feat: Add bot instance cache#56163
Merged
nicholasmarais1158 merged 4 commits intobranch/v18from Jul 14, 2025
Merged
Conversation
* feat: Add bot instance cache * Finalise cache implementation and add tests * Appease the linter * Return early in paging logic * Fix import ordering/grouping * Fix test cache setup * Revert BotCache rename * Clean-up commented code * Revert imports order change * Refactor to use generic getter and lister # Conflicts: # lib/auth/authclient/api.go # lib/cache/cache.go # lib/cache/cache_test.go # lib/cache/collections.go
nicholasmarais1158
added
machine-id
no-changelog
rosstimothy
approved these changes
Jul 8, 2025
Comment on lines
+65
to
+75
| var out []*machineidv1.BotInstance | ||
| clientutils.IterateResources(ctx, | ||
| func(ctx context.Context, limit int, start string) ([]*machineidv1.BotInstance, string, error) { | ||
| return upstream.ListBotInstances(ctx, "", limit, start, "") | ||
| }, | ||
| func(hcc *machineidv1.BotInstance) error { | ||
| out = append(out, hcc) | ||
| return nil | ||
| }, | ||
| ) | ||
| return out, nil |
Contributor
There was a problem hiding this comment.
Suggested change
| var out []*machineidv1.BotInstance | |
| clientutils.IterateResources(ctx, | |
| func(ctx context.Context, limit int, start string) ([]*machineidv1.BotInstance, string, error) { | |
| return upstream.ListBotInstances(ctx, "", limit, start, "") | |
| }, | |
| func(hcc *machineidv1.BotInstance) error { | |
| out = append(out, hcc) | |
| return nil | |
| }, | |
| ) | |
| return out, nil | |
| out, err := stream.Collect(clientutils.Resources(ctx, | |
| func(ctx context.Context, limit int, start string) ([]*machineidv1.BotInstance, string, error) { | |
| return upstream.ListBotInstances(ctx, "", limit, start, "", nil) | |
| }, | |
| )) | |
| return out, trace.Wrap(err) |
boxofrad
approved these changes
Jul 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
nicholasmarais1158
deleted the
nicholasmarais1158/backport-55807-branch/v18
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #55807 to branch/v18