Skip to content

[v18] Fix flaky TestServer_generateAgentVersionReport #56015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoShaka merged 1 commit into from
Jun 24, 2025
Merged

[v18] Fix flaky TestServer_generateAgentVersionReport #56015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/auth/agent_version_report_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,14 @@ func TestServer_generateAgentVersionReport(t *testing.T) {
UpdaterInfo: &types.UpdaterV2Info{UpdaterStatus: status, UpdateGroup: fixture.updateGroup},
})
if fixture.goodbye != nil {
// Sending the message twice is a little hack to make sure that the auth received the goodbye at
// least once. Else, the auth might still be in the small frame when it received the message
// over the channel but has not stored it yet. When this happens the test becomes flaky.
// Ideally we would peek into the inventory internals and wait for the goodbye to be stored,
// but we don't have access to inventory's private field.
// Because the channel is not buffered and a single go routine is reading on the other side, we know
// that the routine is done processing the first messages if we can send the second.
stream.fakeMsg(fixture.goodbye)
stream.fakeMsg(fixture.goodbye)
}
t.Cleanup(stream.close)
Expand Down
Loading