[v17] DB multi-session MFA#55736
Merged
greedy52 merged 5 commits intobranch/v17from Jun 25, 2025
Merged
Conversation
* Implement basic "tsh db exec" * adding ut * minor refactor, fix race, rename iter func * add help * always use service name * overwrite max connections with env var * single get databases call * remove prefix output * fix some flags * iterutils * ensure each database * add summery * refactor, tests * revert auto rename change by editor * revert migrate * remove unused var * review comments * renaming --max-connections to --parallel * make exec return result instead of error * hint TELEPORT_PARALLEL_JOBS * fix golint * address PR comments
* enable multi-session mfa * add ut * add lib/client ut * fix ut and proofread * result.MFAResponse --> result.ReusableMFAResponse * use errors.Is * address comments
5df35b4 to
7b4756e
Compare
|
@greedy52 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
Tener
approved these changes
Jun 16, 2025
GavinFrazar
approved these changes
Jun 16, 2025
r0mant
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #53296 to branch/v17
backport of #54069 to branch/v17
Changelog: Added support for
tsh db execwhich executes commands across multiple target databases. When per-session MFA is required, only one MFA prompt is needed within a 5-minute window.minor cherry-pick conflict. retested with v17 build.
feature is also tested in v18 release testing.