Skip to content

[v17] DB multi-session MFA#55736

Merged
greedy52 merged 5 commits intobranch/v17from
STeve/backport-53296-branch/v17
Jun 25, 2025
Merged

[v17] DB multi-session MFA#55736
greedy52 merged 5 commits intobranch/v17from
STeve/backport-53296-branch/v17

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Jun 13, 2025

backport of #53296 to branch/v17
backport of #54069 to branch/v17

Changelog: Added support for tsh db exec which executes commands across multiple target databases. When per-session MFA is required, only one MFA prompt is needed within a 5-minute window.

minor cherry-pick conflict. retested with v17 build.

feature is also tested in v18 release testing.

greedy52 and others added 3 commits June 13, 2025 13:08
* Implement basic "tsh db exec"

* adding ut

* minor refactor, fix race, rename iter func

* add help

* always use service name

* overwrite max connections with env var

* single get databases call

* remove prefix output

* fix some flags

* iterutils

* ensure each database

* add summery

* refactor, tests

* revert auto rename change by editor

* revert migrate

* remove unused var

* review comments

* renaming --max-connections to --parallel

* make exec return result instead of error

* hint TELEPORT_PARALLEL_JOBS

* fix golint

* address PR comments
* enable multi-session mfa

* add ut

* add lib/client ut

* fix ut and proofread

* result.MFAResponse --> result.ReusableMFAResponse

* use errors.Is

* address comments
@greedy52 greedy52 self-assigned this Jun 13, 2025
@greedy52 greedy52 changed the title DB multi-session MFA [v17] DB multi-session MFA Jun 13, 2025
@greedy52 greedy52 force-pushed the STeve/backport-53296-branch/v17 branch from 5df35b4 to 7b4756e Compare June 13, 2025 19:33
@greedy52 greedy52 marked this pull request as ready for review June 16, 2025 13:06
@greedy52 greedy52 requested review from Joerger, Tener and r0mant and removed request for r0mant June 16, 2025 13:07
@github-actions github-actions Bot added backport desktop-access size/xl tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Jun 16, 2025
@public-teleport-github-review-bot
Copy link
Copy Markdown

@greedy52 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@github-actions github-actions Bot requested review from GavinFrazar, gzdunek and zmb3 June 16, 2025 13:07
@greedy52 greedy52 added this pull request to the merge queue Jun 25, 2025
Merged via the queue into branch/v17 with commit 479f899 Jun 25, 2025
44 checks passed
@greedy52 greedy52 deleted the STeve/backport-53296-branch/v17 branch June 25, 2025 13:24
@fheinecke fheinecke mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport desktop-access size/xl tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants