DB multi-session MFA Part 2: MFA reuse for GenerateUserCerts#54069
Merged
DB multi-session MFA Part 2: MFA reuse for GenerateUserCerts#54069
Conversation
greedy52
commented
Apr 16, 2025
|
|
||
| failedPrompt := fakePrompt{err: errors.New("prompt failed intentionally")} | ||
|
|
||
| defaultGenerateUserCerts := func(ctx context.Context, req proto.UserCertsRequest) (*proto.Certs, error) { |
1398bc7 to
64e6c76
Compare
41ebbbe to
287bb05
Compare
Contributor
Author
|
@Joerger do you mind take a look at this implementation for reuse? thanks 🙏 |
Joerger
reviewed
Apr 25, 2025
637ed2d to
be97395
Compare
Tener
reviewed
Apr 30, 2025
Contributor
Author
Joerger
approved these changes
May 1, 2025
Tener
approved these changes
May 5, 2025
greedy52
added a commit
that referenced
this pull request
Jun 13, 2025
* enable multi-session mfa * add ut * add lib/client ut * fix ut and proofread * result.MFAResponse --> result.ReusableMFAResponse * use errors.Is * address comments
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
* DB multi-session MFA Part 1: implement basic "tsh db exec" (#53296) * Implement basic "tsh db exec" * adding ut * minor refactor, fix race, rename iter func * add help * always use service name * overwrite max connections with env var * single get databases call * remove prefix output * fix some flags * iterutils * ensure each database * add summery * refactor, tests * revert auto rename change by editor * revert migrate * remove unused var * review comments * renaming --max-connections to --parallel * make exec return result instead of error * hint TELEPORT_PARALLEL_JOBS * fix golint * address PR comments * DB multi-session MFA Part 2: MFA reuse for GenerateUserCerts (#54069) * enable multi-session mfa * add ut * add lib/client ut * fix ut and proofread * result.MFAResponse --> result.ReusableMFAResponse * use errors.Is * address comments * fix logger * fix test * remove new tests from master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related:
Changelog: New
tsh db execthat executes commands on multiple target databases. When per-session MFA is required, only a single MFA tap is needed every 5 minutes.The change may seem big but most files are only touched because of refactoring.
Sample role:
Sample
tsh db execrun: