Fix improper redirect URL validation for /web/sso_confirm#55398
Merged
Fix improper redirect URL validation for /web/sso_confirm#55398
/web/sso_confirm#55398Conversation
…or proxy redirect. * Ensure /web/sso_confirm is used as a relative redirect URL during callback.
Joerger
changed the title
for/web/sso_confirm/web/sso_confirm
Collaborator
|
@Joerger Please don't forget to backport this to v18 before the release. |
r0mant
approved these changes
Jun 4, 2025
hugoShaka
approved these changes
Jun 4, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from https://github.com/gravitational/teleport-private/pull/1975
Changelog: Fix improper redirect URL validation for SSO login which could be taken advantage of in a phishing attack.
Note: already backported to v17