[v17] Azure DevOps token source and validator (#54667)#54836
Merged
strideynet merged 2 commits intobranch/v17from May 16, 2025
Merged
[v17] Azure DevOps token source and validator (#54667)#54836strideynet merged 2 commits intobranch/v17from
strideynet merged 2 commits intobranch/v17from
Conversation
* Initial impl of token source * Add initial token validator implementation * add join attrs for azure devops * Switch to Zitadel OIDC * Embed zoidc.TokenClaims into main IDTokenClaims struct * Add notes on caching * Expand concept of token validator * Start hacking on test suite * JoinAttrs method * Fix TestIDTokenValidator_Validate suite * Update OIDC doc to match real one * Add TestIDTokenSource * go mod tidy * rearrange go.mod * fix query params * RepositoryReference -> RepositoryRef * Switch to azuredevops * Adjust struct init * Update lib/azuredevops/token_validator.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
ryanclark
approved these changes
May 15, 2025
boxofrad
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #54667