Azure DevOps token source and validator#54667
Merged
strideynet merged 19 commits intomasterfrom May 13, 2025
Merged
Conversation
rosstimothy
reviewed
May 9, 2025
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/coreos/go-oidc/v3/oidc" |
Contributor
There was a problem hiding this comment.
All my bonusly points if you use zitadel/oidc/v3 instead !!
Contributor
Author
There was a problem hiding this comment.
Done - I've omitted caching JWKS across joins for now since I figure it'll make more sense to put that in once more than 1 join method uses the new zitadel package.
strideynet
added
the
no-changelog
timothyb89
approved these changes
May 13, 2025
timothyb89
reviewed
May 13, 2025
boxofrad
approved these changes
May 13, 2025
strideynet
force-pushed
the
strideynet/azure-devops-protos-validation
branch
from
a8e1d45 to
7972945
Compare
rosstimothy
reviewed
May 13, 2025
| github.com/ghodss/yaml v1.0.0 | ||
| github.com/go-git/go-git/v5 v5.16.0 | ||
| github.com/go-jose/go-jose/v3 v3.0.4 | ||
| github.com/go-jose/go-jose/v4 v4.0.5 |
Contributor
There was a problem hiding this comment.
Should we be thinking about moving all uses of go-jose/v3 to go-jose/v4?
Contributor
Author
There was a problem hiding this comment.
I used go-jose v4 in the tests here since that is what was being used indirectly by the Zitadel OIDC package.
As for if we ought to migrate more fully - it looks like v4 mostly included breaking changes to make it harder to footgun common JWT vulnerabilities (https://github.com/go-jose/go-jose/releases/tag/v4.0.0) - most of these should be pretty easy to adopt. I don't think there's any rush though since they seem to be still releasing new patches for v3.
Base automatically changed from
strideynet/azure-devops-protos-validation
to
master
May 13, 2025 12:45
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
strideynet
force-pushed
the
strideynet/azure-devops-source-and-validator
branch
from
f45bfb1 to
75be296
Compare
strideynet
added a commit
that referenced
this pull request
May 14, 2025
* Initial impl of token source * Add initial token validator implementation * add join attrs for azure devops * Switch to Zitadel OIDC * Embed zoidc.TokenClaims into main IDTokenClaims struct * Add notes on caching * Expand concept of token validator * Start hacking on test suite * JoinAttrs method * Fix TestIDTokenValidator_Validate suite * Update OIDC doc to match real one * Add TestIDTokenSource * go mod tidy * rearrange go.mod * fix query params * RepositoryReference -> RepositoryRef * Switch to azuredevops * Adjust struct init * Update lib/azuredevops/token_validator.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
strideynet
added a commit
that referenced
this pull request
May 15, 2025
* Initial impl of token source * Add initial token validator implementation * add join attrs for azure devops * Switch to Zitadel OIDC * Embed zoidc.TokenClaims into main IDTokenClaims struct * Add notes on caching * Expand concept of token validator * Start hacking on test suite * JoinAttrs method * Fix TestIDTokenValidator_Validate suite * Update OIDC doc to match real one * Add TestIDTokenSource * go mod tidy * rearrange go.mod * fix query params * RepositoryReference -> RepositoryRef * Switch to azuredevops * Adjust struct init * Update lib/azuredevops/token_validator.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2025
* Azure DevOps token source and validator (#54667) * Initial impl of token source * Add initial token validator implementation * add join attrs for azure devops * Switch to Zitadel OIDC * Embed zoidc.TokenClaims into main IDTokenClaims struct * Add notes on caching * Expand concept of token validator * Start hacking on test suite * JoinAttrs method * Fix TestIDTokenValidator_Validate suite * Update OIDC doc to match real one * Add TestIDTokenSource * go mod tidy * rearrange go.mod * fix query params * RepositoryReference -> RepositoryRef * Switch to azuredevops * Adjust struct init * Update lib/azuredevops/token_validator.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * go mod tidy --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #38852
As per: #54341
Depends on #54658
Introduces core implementation for the token source and for the token validator, as well as workload id join attrs.
No backport labels or changelog as all stacked PRs will be backported together.