fix: release PIV connection during PIN prompts - avoid "the smart card has been reset" error#54700
Merged
fix: release PIV connection during PIN prompts - avoid "the smart card has been reset" error#54700
Conversation
6697809 to
d04e686
Compare
tigrato
previously approved these changes
May 13, 2025
fb46c6e to
7f7ae68
Compare
7f7ae68 to
6f52942
Compare
d0e33c2 to
9c1f726
Compare
…ther down the callstack to allow better concurrent access; Add attestMu to prevent certificate corruption.
Contributor
Author
|
Reviewers, I took out a substantial portion of the initial changes (the retry on |
- Add exclusiveOperationMu mutex and test.
59dcc34 to
91846da
Compare
rosstimothy
reviewed
May 19, 2025
bc2dedb to
9c434b4
Compare
rosstimothy
reviewed
May 21, 2025
tigrato
reviewed
May 21, 2025
rosstimothy
reviewed
May 21, 2025
rosstimothy
approved these changes
May 22, 2025
Contributor
Author
|
@tigrato friendly ping to review |
tigrato
approved these changes
May 23, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix an issue with Hardware Key Support on Windows where a command would fail if the PIN prompt was not answered within 5 seconds.
Changes:
Refactor PIV connection sharing logic to enable any PIV request to reconnect and retry after the 5 second timeoutPlease see go-piv/piv-go#172, go-piv/piv-go#173, and go-piv/piv-go#174 for more context.
Fixes #54332