[v17] Remove non-Bourne-shell-compatible script option#54429
Merged
vapopov merged 1 commit intobranch/v17from May 1, 2025
Merged
[v17] Remove non-Bourne-shell-compatible script option#54429vapopov merged 1 commit intobranch/v17from
vapopov merged 1 commit intobranch/v17from
Conversation
I mistakenly used `-o pipefail` in the autoupdate default installer options while the script is executed by sh and not bash. This slipped through testing because some distros are linking `sh` to `bash`.
vapopov
approved these changes
May 1, 2025
r0mant
approved these changes
May 1, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from sclevine
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
adglert
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #54425 to branch/v17
changelog: Fix a bug in the EC2 installer script causing
Illegal option -o pipefailerrors on several distros when Managed Updates v2 are enabled.