Skip to content

Remove non-Bourne-shell-compatible script option#54425

Merged
hugoShaka merged 1 commit intomasterfrom
hugo/fix-54424-broken-sh-script
Apr 30, 2025
Merged

Remove non-Bourne-shell-compatible script option#54425
hugoShaka merged 1 commit intomasterfrom
hugo/fix-54424-broken-sh-script

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

I mistakenly used -o pipefail in the autoupdate default installer options while the script is executed by sh and not bash.

This slipped through testing because some distros are linking sh to bash.

Fixes: #54424
Changelog: Fix a bug in the EC2 installer script causing Illegal option -o pipefail errors on several distros when Managed Updates v2 are enabled.

I mistakenly used `-o pipefail` in the autoupdate default installer
options while the script is executed by sh and not bash.

This slipped through testing because some distros are linking `sh` to
`bash`.
@hugoShaka hugoShaka enabled auto-merge April 30, 2025 21:53
@hugoShaka hugoShaka added this pull request to the merge queue Apr 30, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2025
@hugoShaka hugoShaka added this pull request to the merge queue Apr 30, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2025
@hugoShaka hugoShaka added this pull request to the merge queue Apr 30, 2025
Merged via the queue into master with commit 6af2dc0 Apr 30, 2025
47 checks passed
@hugoShaka hugoShaka deleted the hugo/fix-54424-broken-sh-script branch April 30, 2025 23:43
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@hugoShaka See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default installer does not work with /bin/sh

4 participants