feat: Hardware Key Agent - Initialize client.Store and hardwarekey.Service once per client process#53707
Closed
feat: Hardware Key Agent - Initialize client.Store and hardwarekey.Service once per client process#53707
client.Store and hardwarekey.Service once per client process#53707Conversation
Joerger
force-pushed
the
joerger/key-info
branch
from
8a52b06 to
40e294e
Compare
Joerger
force-pushed
the
joerger/init-hardware-key-service
branch
from
6a8e10b to
a785f31
Compare
Joerger
force-pushed
the
joerger/key-info
branch
from
40e294e to
1ba6865
Compare
Joerger
force-pushed
the
joerger/key-info
branch
from
1ba6865 to
07aaedc
Compare
Joerger
force-pushed
the
joerger/init-hardware-key-service
branch
from
a785f31 to
983c196
Compare
Joerger
force-pushed
the
joerger/key-info
branch
from
07aaedc to
9d652e2
Compare
Joerger
force-pushed
the
joerger/init-hardware-key-service
branch
from
983c196 to
dcc1c2d
Compare
Joerger
force-pushed
the
joerger/key-info
branch
2 times, most recently
from
b68108f to
0931e80
Compare
Joerger
force-pushed
the
joerger/init-hardware-key-service
branch
from
dcc1c2d to
f944298
Compare
Joerger
force-pushed
the
joerger/key-info
branch
3 times, most recently
from
32edb34 to
35156bf
Compare
…s so that the default value (false) results in the desired default behavior.
* Add SetPrompt method to hardwarekey.Service interface and remove CustomHardwareKeyPrompt client config option
* Require ClientStore to be provided in config * Remove CustomHardwareKeyPrompt from config
Joerger
force-pushed
the
joerger/init-hardware-key-service
branch
from
f944298 to
cc41f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RFD 199
Ensure that a single hardware key service, and client store, is used per client process. This ensures that new hardware key service features (hardware key agent, pin caching, yubikey connection caching) works properly and that the client is not competing with itself (in different goroutines) for resources.
Caveat: This change only applies to
tsh,tctl, and Teleport Connect.tbot,api/client, andintegrationsneed additional work.TODO: move some of these changes out to separate PRs
Depends on #53703