[v17] Web: Add filters and pinning support for Enroll Resources page#52176
Merged
kimlisa merged 4 commits intobranch/v17from Feb 20, 2025
Merged
[v17] Web: Add filters and pinning support for Enroll Resources page#52176kimlisa merged 4 commits intobranch/v17from
kimlisa merged 4 commits intobranch/v17from
Conversation
* Web: Move resource specs into resource directory * Web: move code out into separate files
…nce field (#51672) * Add discover resource preferences to user preferences * Define hard coded guide id consts * Set guide ids for resources * Add test * Address CRs * Define a new type just for SelectResource.tsx which requires id field
…52017) This allows us to use "nil" value to mean no discover guide preferences set (which is used to set default values in the web UI).
* Minor changes - Stop propagation and default behavior when clicking on pin button - Add small or large icon option for discover icons * Add pinning guide support * Fix lint
flyinghermit
approved these changes
Feb 15, 2025
avatus
approved these changes
Feb 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports of #51698 #51672 #52017 #51893
the only conflict had to do with the
pb.gofiles which were resolved withmake grpcchangelog: Add filter drop-downs and pinning support for the "Enroll a New Resource" page in the web UI