Wrap discover guide preference "pinned" field inside a proto message#52017
Merged
Wrap discover guide preference "pinned" field inside a proto message#52017
Conversation
This allows us to use "nil" value to mean no discover guide preferences set (which is used to set default values in the web UI).
1 task
avatus
approved these changes
Feb 11, 2025
flyinghermit
approved these changes
Feb 11, 2025
kimlisa
added
the
no-changelog
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
kimlisa
added a commit
that referenced
this pull request
Feb 14, 2025
…52017) This allows us to use "nil" value to mean no discover guide preferences set (which is used to set default values in the web UI).
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…ravitational#52017) This allows us to use "nil" value to mean no discover guide preferences set (which is used to set default values in the web UI).
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
…52176) * Web: make SelectResource.tsx component leaner (#51698) * Web: Move resource specs into resource directory * Web: move code out into separate files * Web: define discover resource guide ids and add discover user preference field (#51672) * Add discover resource preferences to user preferences * Define hard coded guide id consts * Set guide ids for resources * Add test * Address CRs * Define a new type just for SelectResource.tsx which requires id field * Wrap discover guide preference "pinned" field inside a proto message (#52017) This allows us to use "nil" value to mean no discover guide preferences set (which is used to set default values in the web UI). * Web: Add filters and pinning support for Enroll Resources page (#51893) * Minor changes - Stop propagation and default behavior when clicking on pin button - Add small or large icon option for discover icons * Add pinning guide support * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per review, we want the ability for user to clear away pins if they choose to. This PR allows us to use the "nil" value for a guide preference, to mean no discover guide preferences set (which is used to set default values in the web UI).
The original commit was unintended on my part. I didn't realize
omitemptyapplied to both an explicit empty array and an undefined array in the backend