Move IsFIPSDisabledByEnv to lib/utils/aws/awsfips#52123
Merged
codingllama merged 1 commit intomasterfrom Feb 14, 2025
Merged
Conversation
codingllama
added
the
no-changelog
Contributor
Author
|
No backport labels at it'll be cherry-picked as part of #52065 backports. |
espadolini
approved these changes
Feb 13, 2025
codingllama
force-pushed
the
codingllama/aws-fips-cycle
branch
from
227cb32 to
966555e
Compare
codingllama
changed the title
This was referenced Feb 13, 2025
GavinFrazar
approved these changes
Feb 13, 2025
Contributor
Author
|
Thanks for the quick reviews, folks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an import cycle between lib/utils/aws/stsutils (and any other utils package) and lib/utils/aws.
The cycle doesn't happen in master, but it will happen in release branches. This PR helps to keep the code in sync.