Apply the _DISABLE_AWS_FIPS setting to iam and stscreds#52065
Merged
codingllama merged 5 commits intomasterfrom Feb 12, 2025
Merged
Apply the _DISABLE_AWS_FIPS setting to iam and stscreds#52065codingllama merged 5 commits intomasterfrom
codingllama merged 5 commits intomasterfrom
Conversation
github-actions
Bot
added
application-access
database-access
codingllama
added
the
no-changelog
Contributor
Author
|
I'm still holding the more forceful codingllama/aws-fips-3 in reserve, let's land these in a release and see if folks still have problems first. |
codingllama
commented
Feb 12, 2025
| if awsutils.IsFIPSDisabledByEnv() { | ||
| c = fipsDisabledProvider{provider: c} | ||
| } | ||
| return stscreds.NewCredentials(c, roleARN, options...) |
Contributor
Author
There was a problem hiding this comment.
Sadly I could not find a way to test this one: the *credentials.Credentials completely hide the config behind (a chain of) private fields.
GavinFrazar
approved these changes
Feb 12, 2025
nklaassen
approved these changes
Feb 12, 2025
codingllama
force-pushed
the
codingllama/aws-fips-2
branch
from
78ae548 to
935ad61
Compare
public-teleport-github-review-bot
Bot
removed request for
greedy52 and
rosstimothy
|
@codingllama See the table below for backport results.
|
This was referenced Feb 13, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…l#52065) * Add the iamutils package * Add stsutils.NewCredentialsV1() * Use iamutils.NewFromConfig() * Use stsutils.NewCredentialsV1() * Add forbidigo rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the TELEPORT_UNSTABLE_DISABLE_AWS_FIPS=yes environment variable to iam and stscreds clients.
Follow up from #51932 (review).