Skip to content

GitHub proxy: emit rbac failure event and add prometheus counters#51878

Merged
greedy52 merged 2 commits intomasterfrom
STeve/51826_git_rbac_failure_event
Feb 21, 2025
Merged

GitHub proxy: emit rbac failure event and add prometheus counters#51878
greedy52 merged 2 commits intomasterfrom
STeve/51826_git_rbac_failure_event

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Feb 5, 2025

fixes #51826

changelog: Fixed missing audit event on GitHub proxy RBAC failure

Comment thread lib/srv/authhandlers.go Outdated
Copy link
Copy Markdown
Contributor

@kopiczko kopiczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Comment thread lib/srv/authhandlers.go Outdated
@greedy52 greedy52 requested review from kopiczko and zmb3 February 6, 2025 15:23
Comment thread lib/srv/git/forward.go
@greedy52
Copy link
Copy Markdown
Contributor Author

friendly ping @timothyb89 @fspmarshall

@greedy52 greedy52 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 4696be3 Feb 21, 2025
@greedy52 greedy52 deleted the STeve/51826_git_rbac_failure_event branch February 21, 2025 16:37
@public-teleport-github-review-bot
Copy link
Copy Markdown

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Failed

greedy52 added a commit that referenced this pull request Feb 24, 2025
…1878)

* GitHub proxy: emit rbac failure event and add prometheus counters

* move device metadata to sshca.identity
github-merge-queue Bot pushed a commit that referenced this pull request Feb 24, 2025
…1878) (#52427)

* GitHub proxy: emit rbac failure event and add prometheus counters

* move device metadata to sshca.identity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Proxy resource RBAC failure does not emit auth attempt failure event

4 participants