[v17] Fetch RequiredApps when resolving app with fqdnHint only#51873
Merged
avatus merged 1 commit intobranch/v17from Feb 7, 2025
Merged
[v17] Fetch RequiredApps when resolving app with fqdnHint only#51873avatus merged 1 commit intobranch/v17from
avatus merged 1 commit intobranch/v17from
Conversation
If an app is accessed via a bookmark or other means _without_ clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way. After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params. If that isn't supplied, we can fallback to the cluster name in resolved app spec instead. Fixes #51140
kimlisa
approved these changes
Feb 5, 2025
marcoandredinis
approved these changes
Feb 7, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #51800 to branch/v17
changelog: Fixed an issue where required apps wouldn't be authenticated when launching an application from outside the Teleport Web UI.