Fetch RequiredApps when resolving app with fqdnHint only#51800
Merged
Conversation
If an app is accessed via a bookmark or other means _without_ clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way. After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params. If that isn't supplied, we can fallback to the cluster name in resolved app spec instead. Fixes #51140
avatus
force-pushed
the
avatus/fix_redirects
branch
from
306d111 to
ef734bd
Compare
ryanclark
approved these changes
Feb 4, 2025
kimlisa
approved these changes
Feb 4, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from tcsc
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
avatus
added a commit
that referenced
this pull request
Feb 5, 2025
If an app is accessed via a bookmark or other means _without_ clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way. After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params. If that isn't supplied, we can fallback to the cluster name in resolved app spec instead. Fixes #51140
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
…1884) If an app is accessed via a bookmark or other means _without_ clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way. After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params. If that isn't supplied, we can fallback to the cluster name in resolved app spec instead. Fixes #51140
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…al#51800) If an app is accessed via a bookmark or other means _without_ clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way. After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params. If that isn't supplied, we can fallback to the cluster name in resolved app spec instead. Fixes gravitational#51140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an app is accessed via a bookmark or other means without clicking the "Launch" button in the web UI, we only have access to the fqdn and try to resolve the app that way.
After resolution we then try to resolve the app names stored in the required apps spec. This however relied on the clusterName in the params.
If that isn't supplied, we can fallback to the cluster name in resolved app spec instead.
Fixes #51140
changelog: Fixed an issue where required apps wouldn't be authenticated when launching an application from outside the Teleport Web UI.