[v17] Improve instance join error message#51779
Merged
rosstimothy merged 1 commit intobranch/v17from Feb 3, 2025
Merged
Conversation
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
force-pushed
the
tross/backport-51714/v17
branch
from
9d92159 to
2ccbfcf
Compare
marcoandredinis
approved these changes
Feb 3, 2025
zmb3
approved these changes
Feb 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #51714 to branch/v17
changelog: improve
instance.joinevent error messaging.