Improve instance join error message#51714
Merged
rosstimothy merged 1 commit intomasterfrom Feb 3, 2025
Merged
Conversation
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
force-pushed
the
tross/instance_join_error_message
branch
from
6e2b802 to
9fdd317
Compare
zmb3
approved these changes
Jan 31, 2025
marcoandredinis
approved these changes
Feb 3, 2025
public-teleport-github-review-bot
Bot
removed request for
kiosion and
timothyb89
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
rosstimothy
added a commit
that referenced
this pull request
Feb 3, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces context cancellation messages with a nicer and more intuitive message that folks unfamiliar with Go and gRPC will understand.
changelog: improve
instance.joinevent error messaging.