Skip to content

Quote KUBECONFIG output by tsh proxy kube #51509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosstimothy merged 1 commit into from
Jan 27, 2025
Merged

Quote KUBECONFIG output by tsh proxy kube #51509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tool/tsh/common/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,13 +882,13 @@ func envVarDefaultFormat() string {
func envVarCommand(format, key, value string) (string, error) {
switch format {
case envVarFormatUnix:
return fmt.Sprintf("export %s=%s", key, value), nil
return fmt.Sprintf(`export %s="%s"`, key, value), nil

case envVarFormatWindowsCommandPrompt:
return fmt.Sprintf("set %s=%s", key, value), nil

case envVarFormatWindowsPowershell:
return fmt.Sprintf("$Env:%s=\"%s\"", key, value), nil
return fmt.Sprintf(`$Env:%s="%s"`, key, value), nil

case envVarFormatText:
return fmt.Sprintf("%s=%s", key, value), nil
Expand Down
4 changes: 2 additions & 2 deletions tool/tsh/common/proxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ func TestEnvVarCommand(t *testing.T) {
inputFormat: envVarFormatUnix,
inputKey: "key",
inputValue: "value",
expectOutput: "export key=value",
expectOutput: `export key="value"`,
},
{
inputFormat: envVarFormatWindowsCommandPrompt,
Expand All @@ -849,7 +849,7 @@ func TestEnvVarCommand(t *testing.T) {
inputFormat: envVarFormatWindowsPowershell,
inputKey: "key",
inputValue: "value",
expectOutput: "$Env:key=\"value\"",
expectOutput: `$Env:key="value"`,
},
{
inputFormat: "unknown",
Expand Down