Quote KUBECONFIG output by tsh proxy kube#51509
Merged
rosstimothy merged 1 commit intomasterfrom Jan 27, 2025
Merged
Conversation
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes #36455.
rosstimothy
force-pushed
the
tross/quote_kube_config
branch
from
4cd6c53 to
b9c50ba
Compare
github-actions
Bot
added
size/sm
tsh
greedy52
approved these changes
Jan 27, 2025
zmb3
approved these changes
Jan 27, 2025
public-teleport-github-review-bot
Bot
removed request for
eriktate and
ravicious
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Jan 27, 2025
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes #36455.
rosstimothy
added a commit
that referenced
this pull request
Jan 27, 2025
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes #36455.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes #36455.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes #36455.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64, Closes gravitational#36455.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of the kube config location is now explicitly quoted when the template is executed. This is similar to what other tools do, see https://github.com/lima-vm/lima/blob/ccd3c0cb9fdbef18ee82263a712ac8924a0deca8/templates/k3s.yaml#L64,
Closes #36455.
Changelog: Quote the KUBECONFIG environment variable output by the
tsh proxy kubecommand