Skip to content

Prevent panicking during shutdown when SQS consumer is disabled#50643

Merged
lcharkiewicz merged 1 commit intomasterfrom
leszek/fix-disabled-consumer-panic
Dec 31, 2024
Merged

Prevent panicking during shutdown when SQS consumer is disabled#50643
lcharkiewicz merged 1 commit intomasterfrom
leszek/fix-disabled-consumer-panic

Conversation

@lcharkiewicz
Copy link
Copy Markdown
Contributor

Fixing a panic when SQS consumer is disabled and auth is closing the Audit Logger.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x55659d2f4e1a]

goroutine 6295 [running]:
github.com/gravitational/teleport/lib/events/athena.(*Log).Close(0x0?)
        github.com/gravitational/teleport/lib/events/athena/athena.go:546 +0x1a
github.com/gravitational/teleport/lib/events.(*AuditLog).Close(0xc0015f8c00)
        github.com/gravitational/teleport/lib/events/auditlog.go:1075 +0x59
github.com/gravitational/teleport/lib/auth.(*Server).Close(0xc0015b2c08)
        github.com/gravitational/teleport/lib/auth/auth.go:1849 +0x72
github.com/gravitational/teleport/lib/service.(*TeleportProcess).StartShutdown.func1()
        github.com/gravitational/teleport/lib/service/service.go:6012 +0x17f
created by github.com/gravitational/teleport/lib/service.(*TeleportProcess).StartShutdown in goroutine 1
        github.com/gravitational/teleport/lib/service/service.go:6004 +0x2d8

Disabling consumer was added in #46770.

Changelog: Prevent panicking during shutdown when SQS consumer is disabled

@lcharkiewicz lcharkiewicz marked this pull request as ready for review December 31, 2024 13:20
@github-actions github-actions Bot requested review from atburke and zmb3 December 31, 2024 13:21
@github-actions github-actions Bot added audit-log Issues related to Teleports Audit Log size/sm labels Dec 31, 2024
@lcharkiewicz lcharkiewicz added this pull request to the merge queue Dec 31, 2024
Merged via the queue into master with commit b44d19b Dec 31, 2024
@lcharkiewicz lcharkiewicz deleted the leszek/fix-disabled-consumer-panic branch December 31, 2024 16:23
@public-teleport-github-review-bot
Copy link
Copy Markdown

@lcharkiewicz See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log backport/branch/v17 size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants