Add support for custom SQS consumer lock and disabling consumer#46770
Add support for custom SQS consumer lock and disabling consumer#46770lcharkiewicz merged 8 commits intomasterfrom
Conversation
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
I have no strong opinions on the names used, LGTM
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
lcharkiewicz
force-pushed
the
leszek/sqs-consumer-locking-disabling
branch
from
97ef500 to
5b9d359
Compare
|
Updated to use LockNameComponents and disabling a consumer. Let me know if that part requires more tests. |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
github-actions
Bot
added
audit-log
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
I don't like how we pass along an arbitrary sequence of lock name components when we know it's either athena_lock or athena/<foo>, the rest all seems good.
|
Remember to also update the athenaevents docs (in a separate PR so reviewer checks won't complain), depending on if (and when) we intend to support this for onprem. |
|
(we are not supporting |
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
|
@lcharkiewicz See the table below for backport results.
|
|
@lcharkiewicz See the table below for backport results.
|
3 participants
Adding support for custom SQS consumer lock name and disabling a consumer.
Changelog: Adds support for custom SQS consumer lock name and disabling a consumer.
Goal: gravitational/cloud#10164