[v16] devicetrust: don't invoke powershell when reading system information#50454
Merged
zmb3 merged 1 commit intobranch/v16from Dec 19, 2024
Merged
[v16] devicetrust: don't invoke powershell when reading system information#50454zmb3 merged 1 commit intobranch/v16from
zmb3 merged 1 commit intobranch/v16from
Conversation
The device trust web flow can result in a web browser launching Teleport Connect (which launches tsh, which in turn launches powershell). Some antivirus solutions flag cases where a powershell process is a descendent of a web browser process. In order to avoid being blocked by the antivirus software, we want to read system information directly instead of via powershell.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rosstimothy
approved these changes
Dec 19, 2024
codingllama
approved these changes
Dec 19, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device trust web flow can result in a web browser launching Teleport Connect (which launches tsh, which in turn launches powershell).
Some antivirus solutions flag cases where a powershell process is a descendent of a web browser process. In order to avoid being blocked by the antivirus software, we want to read system information directly instead of via powershell.
Backports #50372
Changelog: Fixed an issue that could cause some antivirus tools to block Teleport's Device Trust feature on Windows machines.