devicetrust: don't invoke powershell when reading system information#50372
Merged
devicetrust: don't invoke powershell when reading system information#50372
Conversation
zmb3
force-pushed
the
zmb3/windows-no-powershell
branch
from
43238f9 to
d3a0484
Compare
Collaborator
Author
|
Result of 
@codingllama @ravicious @gzdunek would any of you mind trying |
Member
|
I don't have Windows on my Thinkpad, but I know that @nklaassen has a Windows machine. 😏 |
codingllama
reviewed
Dec 19, 2024
The device trust web flow can result in a web browser launching Teleport Connect (which launches tsh, which in turn launches powershell). Some antivirus solutions flag cases where a powershell process is a descendent of a web browser process. In order to avoid being blocked by the antivirus software, we want to read system information directly instead of via powershell.
zmb3
force-pushed
the
zmb3/windows-no-powershell
branch
from
79f0e4e to
cef8d83
Compare
codingllama
approved these changes
Dec 19, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
LGTM.
I just did another run with the current commit, to be sure. Looks fine.
rosstimothy
approved these changes
Dec 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…ravitational#50372) The device trust web flow can result in a web browser launching Teleport Connect (which launches tsh, which in turn launches powershell). Some antivirus solutions flag cases where a powershell process is a descendent of a web browser process. In order to avoid being blocked by the antivirus software, we want to read system information directly instead of via powershell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device trust web flow can result in a web browser launching Teleport Connect (which launches tsh, which in turn launches powershell).
Some antivirus solutions flag cases where a powershell process is a descendent of a web browser process. In order to avoid being blocked by the antivirus software, we want to read system information directly instead of via powershell.
Changelog: Fixed an issue that could cause some antivirus tools to block Teleport's Device Trust feature on Windows machines.