Relax validServerHostname to accept -- or ..#50386
Merged
Conversation
This PR updates the regex used by `validServerHostname` to permit consecutive symbols (`-` and `.`) in server hostnames. Changelog: Enable multiple consecutive occurrences of `-` and `.` in SSH server hostnames. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
espadolini
approved these changes
Dec 18, 2024
espadolini
reviewed
Dec 18, 2024
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
espadolini
approved these changes
Dec 18, 2024
capnspacehook
approved these changes
Dec 18, 2024
public-teleport-github-review-bot
bot
removed request for
doggydogworld,
rosstimothy and
strideynet
Merged
mvbrock
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Relax `validServerHostname` to accept `--` or `..` This PR updates the regex used by `validServerHostname` to permit consecutive symbols (`-` and `.`) in server hostnames. Changelog: Enable multiple consecutive occurrences of `-` and `.` in SSH server hostnames. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * revert to old hostname if it was valid under the new rules * fix * run test in parallel * Update lib/auth/auth.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * handle review comments --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Relax `validServerHostname` to accept `--` or `..` This PR updates the regex used by `validServerHostname` to permit consecutive symbols (`-` and `.`) in server hostnames. Changelog: Enable multiple consecutive occurrences of `-` and `.` in SSH server hostnames. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * revert to old hostname if it was valid under the new rules * fix * run test in parallel * Update lib/auth/auth.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * handle review comments --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the regex used by
validServerHostnameto permit consecutive symbols (-and.) in server hostnames.Changelog: Enable multiple consecutive occurrences of
-and.in SSH server hostnames.