[v17] Refactor Reauthenticate components to handle generic MFA challenges.#50354
Merged
Joerger merged 1 commit intobranch/v17from Dec 18, 2024
Merged
[v17] Refactor Reauthenticate components to handle generic MFA challenges.#50354Joerger merged 1 commit intobranch/v17from
Reauthenticate components to handle generic MFA challenges.#50354Joerger merged 1 commit intobranch/v17from
Conversation
Joerger
added
the
no-changelog
zmb3
reviewed
Dec 17, 2024
| return OK(), nil | ||
| } | ||
|
|
||
| type deleteMfaDeviceRequest struct { |
Collaborator
There was a problem hiding this comment.
Suggested change
| type deleteMfaDeviceRequest struct { | |
| type deleteMFADeviceRequest struct { |
Acronyms should be capitalized in Go code.
zmb3
reviewed
Dec 17, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
Author
|
@ryanclark @rosstimothy Friendly ping to review this backport |
ryanclark
approved these changes
Dec 18, 2024
Contributor
|
Looks like the linter isn't happy |
#49680) * Handle unified mfa response to create privileged token. * Refactor useReauthenticate and Reauthenticate component. * Refactor ChangePasswordWizard to use useReauthenticate. * Fix mfa challenge option preference order; Fix reauthenticate component initial mfa option state. * Remove useReAuthenticate's onAuthenticated parameter. * Fix lint. * Fix flaky test. * Remove extra createPrivilegeToken call from the account page; Add new tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+. * Fix tests. * Fix error handling in Web MFA flow. * Update e ref. * Fix stories. * Fix lint.
Joerger
force-pushed
the
joerger/v17/refactor-reauthenticate
branch
from
8ef577f to
69f3830
Compare
Contributor
Author
Yeah branch/v17 has different lint rules from master for some reason, fixed. |
rosstimothy
approved these changes
Dec 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #49680 to branch/v17
e PR - https://github.com/gravitational/teleport.e/pull/5717
Note on /e: This PR is dependent on https://github.com/gravitational/teleport.e/pull/5717 and vice versa. Therefore I'll need to merge this PR with e PR as the head of /e. Then I'll make a follow up to update the e ref to master once the e PR is merged, shortly after this PR is merged.