Refactor Reauthenticate components to handle generic MFA challenges.#49680
Merged
Refactor Reauthenticate components to handle generic MFA challenges.#49680
Reauthenticate components to handle generic MFA challenges.#49680Conversation
0d9623a to
518f3ef
Compare
9d5b285 to
b4e63c1
Compare
e2afc8c to
e53c97c
Compare
Closed
e53c97c to
a36af16
Compare
b4e63c1 to
5eca740
Compare
a36af16 to
037f575
Compare
4abf873 to
42ba430
Compare
avatus
reviewed
Dec 6, 2024
ryanclark
approved these changes
Dec 9, 2024
avatus
approved these changes
Dec 9, 2024
ea8e8eb to
40336ed
Compare
ryanclark
approved these changes
Dec 10, 2024
828bded to
5d0f08d
Compare
…nt initial mfa option state.
… tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+.
5d0f08d to
89e4639
Compare
Joerger
added a commit
that referenced
this pull request
Dec 17, 2024
#49680) * Handle unified mfa response to create privileged token. * Refactor useReauthenticate and Reauthenticate component. * Refactor ChangePasswordWizard to use useReauthenticate. * Fix mfa challenge option preference order; Fix reauthenticate component initial mfa option state. * Remove useReAuthenticate's onAuthenticated parameter. * Fix lint. * Fix flaky test. * Remove extra createPrivilegeToken call from the account page; Add new tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+. * Fix tests. * Fix error handling in Web MFA flow. * Update e ref. * Fix stories. * Fix lint.
This was referenced Dec 17, 2024
Joerger
added a commit
that referenced
this pull request
Dec 18, 2024
#49680) * Handle unified mfa response to create privileged token. * Refactor useReauthenticate and Reauthenticate component. * Refactor ChangePasswordWizard to use useReauthenticate. * Fix mfa challenge option preference order; Fix reauthenticate component initial mfa option state. * Remove useReAuthenticate's onAuthenticated parameter. * Fix lint. * Fix flaky test. * Remove extra createPrivilegeToken call from the account page; Add new tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+. * Fix tests. * Fix error handling in Web MFA flow. * Update e ref. * Fix stories. * Fix lint.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
#49680) (#50354) * Handle unified mfa response to create privileged token. * Refactor useReauthenticate and Reauthenticate component. * Refactor ChangePasswordWizard to use useReauthenticate. * Fix mfa challenge option preference order; Fix reauthenticate component initial mfa option state. * Remove useReAuthenticate's onAuthenticated parameter. * Fix lint. * Fix flaky test. * Remove extra createPrivilegeToken call from the account page; Add new tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+. * Fix tests. * Fix error handling in Web MFA flow. * Update e ref. * Fix stories. * Fix lint.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
gravitational#49680) * Handle unified mfa response to create privileged token. * Refactor useReauthenticate and Reauthenticate component. * Refactor ChangePasswordWizard to use useReauthenticate. * Fix mfa challenge option preference order; Fix reauthenticate component initial mfa option state. * Remove useReAuthenticate's onAuthenticated parameter. * Fix lint. * Fix flaky test. * Remove extra createPrivilegeToken call from the account page; Add new tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+. * Fix tests. * Fix error handling in Web MFA flow. * Update e ref. * Fix stories. * Fix lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overarching change in this PR is the ability of all
Reauthenticateflows to handle generic MFA challenges (sso, webauthn, otp) rather than handling each type differently or not at all.Note:
useReauthenticateshould now be the goto state handler method for reauthentication flows.Changes:
useReauthenticate(used in theReauthenticatecomponents).submitWithMFAmethod instead ofsubmitWithWebAuthnandsubmitWithOTP. SSO MFA will usesubmitWithMFA('sso').OnAuthenticatedpropuseReauthenticaterefactors.useReauthenticatefor change password wizard to get the same changes described above.createPrivilegeTokenendpoint to accept generic MFA response instead of TOTP or Webauthn, so it will now support SSO MFA.Note on
/e: This PR is dependent on the e PR and vice versa. Therefore I'll need to merge this PR with e PR as the head of/e. Then I'll make a follow up to update the e ref to master once the e PR is merged, shortly after this PR is merged.TODO (follow ups):
Prerequisite for supporting SSO MFA in device management (add/delete), connection tester (discover), change password, and account recovery flows.
Depends on #49678, #49679, https://github.com/gravitational/teleport.e/pull/5656