[v16] Support double dash delimiter in tsh ssh#47493
Merged
rosstimothy merged 3 commits intobranch/v16from Nov 4, 2024
Merged
Conversation
This PR extends the tsh ssh command by adding support for the double dash (--) delimiter before remote commands (e.g. `tsh ssh -- echo test`), aligning its behavior with the standard ssh binary. This improves compatibility with tools that rely on the standard ssh binary behavior, such as sshuttle. Fixes #18453, #16589. Signed-off-by: Tim Ross <tim.ross@goteleport.com>
This PR extends the tsh ssh command by adding support for the double dash (--) delimiter before remote commands (e.g. `tsh ssh -- echo test`), aligning its behavior with the standard ssh binary. This improves compatibility with tools that rely on the standard ssh binary behavior, such as sshuttle. Fixes #18453, #16589. Signed-off-by: Tim Ross <tim.ross@goteleport.com>
github-actions
Bot
added
backport
size/md
tsh
espadolini
approved these changes
Oct 11, 2024
marcoandredinis
approved these changes
Oct 14, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #46441 to branch/v16
changelog: Update tsh ssh to support the -- delimiter similar to openssh. It is now possible to execute a command via
tsh ssh user@host -- echo testortsh ssh -- host uptime