Support double dash delimiter in tsh ssh#46441
Merged
rosstimothy merged 3 commits intomasterfrom Sep 11, 2024
Merged
Conversation
rosstimothy
force-pushed
the
tross/pr-buddy-43897
branch
from
5ae1015 to
fbbeb57
Compare
github-actions
Bot
added
size/md
tsh
espadolini
reviewed
Sep 11, 2024
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
Does that allow tsh ssh -- hostname? That's explicitly allowed in OpenSSH ssh.
Contributor
Author
Yes. I'll add a test case for that as well. $ ./build/tsh ssh -- server01 uptime
12:51 up 5 days, 20:41, 6 users, load averages: 1.97 1.96 1.87
$ ./build/tsh ssh tim@server01 -- echo "testing 123"
testing 123
$ ./build/tsh ssh server01 -- echo "testing 123"
testing 123 |
espadolini
approved these changes
Sep 11, 2024
probakowski
approved these changes
Sep 11, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
This PR extends the tsh ssh command by adding support for the double dash (--) delimiter before remote commands (e.g. `tsh ssh -- echo test`), aligning its behavior with the standard ssh binary. This improves compatibility with tools that rely on the standard ssh binary behavior, such as sshuttle. Fixes #18453, #16589. Signed-off-by: Tim Ross <tim.ross@goteleport.com>
This PR extends the tsh ssh command by adding support for the double dash (--) delimiter before remote commands (e.g. `tsh ssh -- echo test`), aligning its behavior with the standard ssh binary. This improves compatibility with tools that rely on the standard ssh binary behavior, such as sshuttle. Fixes #18453, #16589. Signed-off-by: Tim Ross <tim.ross@goteleport.com>
rosstimothy
force-pushed
the
tross/pr-buddy-43897
branch
from
dcc0097 to
c99945c
Compare
|
@rosstimothy See the table below for backport results.
|
This was referenced Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buddies #43897
Originally contributed by @ns-sjorgedeaguiar
Closes #18453 and #16589.
changelog: Update tsh ssh to support the -- delimiter similar to openssh. It is now possible to execute a command via
tsh ssh user@host -- echo testortsh ssh -- host uptime