[v15] [plugins] add plugin audit events boilerplate to CUD operations#46838
Merged
tigrato merged 4 commits intobranch/v15from Oct 3, 2024
Merged
[v15] [plugins] add plugin audit events boilerplate to CUD operations#46838tigrato merged 4 commits intobranch/v15from
tigrato merged 4 commits intobranch/v15from
Conversation
* [plugins] add plugin audit events boilerplate to CUD operations This PR adds the required boilerplate code to emit audit events for `create`, `update` and `delete` operations. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * handle comments --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added
the
no-changelog
github-actions
Bot
added
audit-log
capnspacehook
approved these changes
Oct 1, 2024
smallinsky
approved these changes
Oct 1, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #45161 to branch/v15
Backport of #46830 to branch/v15