drop types.PluginsV1 from audit log payload#46830
Merged
Conversation
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
zmb3
approved these changes
Sep 20, 2024
eriktate
approved these changes
Sep 20, 2024
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling and
codingllama
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
tigrato
added a commit
that referenced
this pull request
Sep 20, 2024
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Sep 21, 2024
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Sep 21, 2024
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…#46838) * [plugins] add plugin audit events boilerplate to CUD operations (#45161) * [plugins] add plugin audit events boilerplate to CUD operations This PR adds the required boilerplate code to emit audit events for `create`, `update` and `delete` operations. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * handle comments --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * drop `types.PluginsV1` from audit log payload (#46830) Okta plugin sets `plugin.spec.settings` which is a one of message and our audit log incorrectly uses `json.Marshal/Unmarshal` to marshal and Unmarshal objects from json. When unmarshaling the oneof, json parser fails because it can't decode the correct message. This PR changes the type to use a `google.protobuf.Struct` so it can hold any static data. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add TimToMaxSize --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okta plugin sets
plugin.spec.settingswhich is a oneof message and our audit log incorrectly usesjson.Marshal/Unmarshalto marshal and Unmarshal objects from json.When unmarshaling the oneof, json parser fails because it can't decode the correct message.
This PR changes the type to use a
google.protobuf.Structso it can hold any static data.Changelog: Fixes a regression that made it impossible to read the Teleport Audit Log after creating a plugin if the audit event is present.