[v15] Allow host user creation when host_groups contain login name#46638
Merged
eriktate merged 1 commit intobranch/v15from Sep 16, 2024
Merged
[v15] Allow host user creation when host_groups contain login name#46638eriktate merged 1 commit intobranch/v15from
host_groups contain login name#46638eriktate merged 1 commit intobranch/v15from
Conversation
eriktate
requested review from
camscale,
codingllama,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones,
tcsc and
zmb3
as code owners
|
@eriktate - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
Bot
added
audit-log
github-actions
Bot
requested review from
Joerger,
bernardjkim,
espadolini,
fspmarshall,
greedy52,
hugoShaka,
kimlisa,
marcoandredinis,
mmcallister,
nklaassen,
probakowski,
ptgott,
ravicious and
smallinsky
eriktate
removed request for
Joerger,
bernardjkim,
camscale,
codingllama,
fheinecke,
fspmarshall,
greedy52,
hugoShaka,
kimlisa,
nklaassen,
ptgott,
rosstimothy,
smallinsky,
strideynet and
xinding33
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
Author
|
Sorry for the ping everyone, accidentally created the backport against |
eriktate
added
backport
size/sm
and removed
documentation
kubernetes-access
bpf
capnspacehook
approved these changes
Sep 16, 2024
tigrato
approved these changes
Sep 16, 2024
group in host_groups
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #46039 to branch/v15
changelog: Fixed an issue that prevented host user creation when the username was also listed in
host_groups.