Allow host user creation when host_groups contain login name#46039
Merged
Allow host user creation when host_groups contain login name#46039
host_groups contain login name#46039Conversation
9b24a2e to
a7252bf
Compare
a7252bf to
8af8702
Compare
avatus
approved these changes
Sep 3, 2024
rosstimothy
reviewed
Sep 4, 2024
f9a6166 to
d6d6f5a
Compare
rosstimothy
reviewed
Sep 11, 2024
capnspacehook
approved these changes
Sep 11, 2024
d2e55aa to
7315ec4
Compare
group in host_groups
7315ec4 to
e973c8f
Compare
This was referenced Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35142
This adds some additonal logic around resolving a primary GID while creating new host users. The expected invariants are:
host_groups.host_groups.host_groups.I'm not entirely sure that last one should be included, but it seemed safer not to automatically assign a user to a group that isn't also managed/mentioned in the role. This can be circumvented by either adding the group name to the
host_groupsin the role, or by explicitly assigning a GID to the user's traits.changelog: Fixed an issue that prevented host user creation when the username was also listed in
host_groups.