Conversation
tigrato
added
the
no-changelog
| teleport.machineid.v1.SPIFFEFederation SPIFFEFederation = 62; | ||
| // StaticHostUser is a resource for static host users. | ||
| teleport.userprovisioning.v1.StaticHostUser StaticHostUser = 63; | ||
| // AutoUpdateConfig is a resource for autoupdate config. |
There was a problem hiding this comment.
Why are the proto changes necessary? Are they part of the fix for k8s.io v1.31.x?
There was a problem hiding this comment.
Tiago re-syced the test snapshots fopr the CRD generation. We use a copy of the proto definitions rather than the real ones in the snapshot tests. It's dumb and not useful, but I never got time to clean this up, so we need to sync the test inputs from time to time.
There was a problem hiding this comment.
This is fine, but I want to understand what is part of the k8s v1.31.x fix and what is just tagging along.
There was a problem hiding this comment.
The protobuf updates are unrelated but since I generated the new CRD stubs, I also updated the protos. I can revert them as they have no interference in the output
tigrato
force-pushed
the
tigrato/bump-sigs.k8s.io/controller-runtime2
branch
from
f420605 to
80182c1
Compare
|
(Sorry for the delay, I thought had approved this already.) |
3 participants
Depends on #46299