Merged
Conversation
This reverts commit 7f35ef1.
codingllama
requested review from
hugoShaka,
nklaassen,
rosstimothy and
tigrato
Contributor
Author
|
Note that Go 1.23.1 isn't on |
tigrato
approved these changes
Sep 5, 2024
rosstimothy
approved these changes
Sep 5, 2024
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Thanks to @nklaassen for making this possible!
public-teleport-github-review-bot
Bot
removed request for
bernardjkim,
hugoShaka and
nklaassen
nklaassen
approved these changes
Sep 5, 2024
Contributor
nklaassen
left a comment
nklaassen
left a comment
There was a problem hiding this comment.
can confirm my original database/sql repro now (correctly) times out instead of panicking https://go.dev/play/p/fHZFq6zgAV4
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores Go 1.23 to both toolchain and module and update it to 1.23.1.
Related PRs: #45473 (restored), #45530 (restored) and #45593 (reverted).
Changelog: Updated Go to 1.23