Conversation
Empty join token responses would show an error instead of an empty list message
avatus
added
backport-required
no-changelog
zmb3
approved these changes
Aug 13, 2024
marcoandredinis
approved these changes
Aug 13, 2024
public-teleport-github-review-bot
Bot
removed request for
kiosion and
ravicious
avatus
added a commit
that referenced
this pull request
Aug 13, 2024
Empty join token responses would show an error instead of an empty list message
Merged
Contributor
Author
|
Backport collected here #44701 |
ravicious
reviewed
Aug 13, 2024
| return api.get(cfg.getJoinTokensUrl(), signal).then(resp => { | ||
| return { | ||
| items: resp.items.map(makeJoinToken), | ||
| items: resp.items?.map(makeJoinToken) || [], |
Member
There was a problem hiding this comment.
Does the API endpoint not include items when there are no items to return?
Contributor
There was a problem hiding this comment.
It includes it, but it's null:
Contributor
Author
There was a problem hiding this comment.
Looks like it has to do with not using zero-length slices.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Add token list/delete endpoints (#42402) This PR implements list/delete for tokens in the api the same way as tctl interacts with them. This does not include pagination yet but is currently being used while the feature is in development. Pagination can come in the future in the form of a sort cache, but the endpoints won't change * Add token ACL/routes * Add initial join tokens UI * Add Allow and GCP fields to ui join token * Fix missing styled components * Fix empty join token state (#45413) Empty join token responses would show an error instead of an empty list message * Update button case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty join token responses would show an error instead of an empty list message