[16] Join Tokens UI#44701
Merged
avatus merged 7 commits intobranch/v16from Aug 26, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
added
the
no-changelog
avatus
requested review from
kimlisa,
rudream and
ryanclark
and removed request for
marcoandredinis,
smallinsky and
zmb3
|
@avatus - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
Contributor
Author
|
The manual backport wasn't as bad as i thought. only missing a prop and some color changes 👍 |
Contributor
Author
|
This backport is now complete and ready for review. thanks team |
r0mant
approved these changes
Jul 26, 2024
Collaborator
|
Let's hold this for 16.2. |
ravicious
approved these changes
Jul 29, 2024
This PR implements list/delete for tokens in the api the same way as tctl interacts with them. This does not include pagination yet but is currently being used while the feature is in development. Pagination can come in the future in the form of a sort cache, but the endpoints won't change
Empty join token responses would show an error instead of an empty list message
avatus
force-pushed
the
avatus/v16/join_tokens
branch
from
9773f49 to
7423e3d
Compare
public-teleport-github-review-bot
Bot
removed request for
kimlisa,
rudream and
ryanclark
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Add token list/delete endpoints (#42402) This PR implements list/delete for tokens in the api the same way as tctl interacts with them. This does not include pagination yet but is currently being used while the feature is in development. Pagination can come in the future in the form of a sort cache, but the endpoints won't change * Add token ACL/routes * Add initial join tokens UI * Add Allow and GCP fields to ui join token * Fix missing styled components * Fix empty join token state (#45413) Empty join token responses would show an error instead of an empty list message * Update button case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #42402, #43766, #42734, #44408, #45413