Fix unintended trace.Wrap(nil) in playFromFileStreamer#42088
Merged
espadolini merged 1 commit intomasterfrom May 28, 2024
Merged
Fix unintended trace.Wrap(nil) in playFromFileStreamer#42088espadolini merged 1 commit intomasterfrom
trace.Wrap(nil) in playFromFileStreamer#42088espadolini merged 1 commit intomasterfrom
Conversation
espadolini
added
backport/branch/v14
no-changelog
rosstimothy
approved these changes
May 28, 2024
atburke
approved these changes
May 28, 2024
|
@espadolini See the table below for backport results.
|
This was referenced May 28, 2024
Contributor
Author
|
For future reference: the v14 backport is not necessary, the player in v14 doesn't stream events like v15+ and the way it fetches events doesn't trigger the bug that this PR fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #42061