Fix goroutine leak in (*UploadCompleter).ensureSessionEndEvent#42061
Merged
espadolini merged 1 commit intomasterfrom May 28, 2024
Merged
Fix goroutine leak in (*UploadCompleter).ensureSessionEndEvent#42061espadolini merged 1 commit intomasterfrom
(*UploadCompleter).ensureSessionEndEvent#42061espadolini merged 1 commit intomasterfrom
Conversation
github-actions
Bot
added
audit-log
zmb3
approved these changes
May 27, 2024
rosstimothy
approved these changes
May 27, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@espadolini See the table below for backport results.
|
This was referenced May 28, 2024
zmb3
reviewed
May 28, 2024
| select { | ||
| case evts <- evt: | ||
| case <-ctx.Done(): | ||
| errs <- trace.Wrap(err) |
Collaborator
There was a problem hiding this comment.
trace.Wrap(err) is guaranteed to evaluate to nil here, right?
Contributor
Author
There was a problem hiding this comment.
It does, this was meant to be errs <-trace.Wrap(ctx.Err()) 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a goroutine leak in the upload completer, which wasn't exhausting the event stream from
StreamSessionEventif a session end event was found. The same sort of leak was also fixed in the failure paths of a handful of tests, and in the code used bytsh playandtsh recordings export(even though it's not a problem for the command line tools, since process exit is the ultimate leak collector anyway).changelog: fixed resource leak in session recording cleanup