[v15] add GCP Spanner#41349
Merged
greedy52 merged 2 commits intobranch/v15from May 29, 2024
Merged
Conversation
GavinFrazar
added
audit-log
GavinFrazar
force-pushed
the
gavinfrazar/v15-gcloud-spanner
branch
from
225c233 to
6dd1dc2
Compare
Contributor
Author
|
@zmb3 same as original PR, this needs a flaky test skip due to 10minute timeout |
Tener
approved these changes
May 9, 2024
r0mant
approved these changes
May 9, 2024
smallinsky
approved these changes
May 10, 2024
GavinFrazar
force-pushed
the
gavinfrazar/v15-gcloud-spanner
branch
from
6dd1dc2 to
79477b2
Compare
* add spanner to tsh and teleterm * handle spanner events in web ui * update web audit events test snapshot * customize web ui connect for spanner * update ConnectDialog snapshot
|
@GavinFrazar - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
public-teleport-github-review-bot
Bot
removed the request for review
from greedy52
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
/excludeflake * |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Added support for GCP Spanner to Teleport Database Service.
backports both:
to branch/v15.
This PR is marked
do-not-mergeuntil we are ready for the v15.4.0 minor release at the end of the month.We do not want to release this in a patch release version.
Reviewers: I backported this manually. There were conflicts in:
go.mod,go.sum,api/proto/teleport/legacy/types/events/events.proto(and corresponding .pb.go). So it was a pretty straightforward backport.the web ui backport cherry-pick only had a conflict in the audit storybook test snapshot, which I resolved with
yarn test-update-snapshotand inspecting the result withyarn storybookto verify it still looks right.