support gcloud spanner in tsh and web UI#41129
Merged
GavinFrazar merged 5 commits intomasterfrom May 7, 2024
Merged
Conversation
ea5e499 to
f0a4cbc
Compare
d907342 to
f5b578b
Compare
greedy52
approved these changes
May 3, 2024
Contributor
Author
|
I think the "buf breaking" lint error is just because this PR is currently based on my other feature branch instead of master, and since I force-pushed that branch it thinks there's been a buf breaking change. It should clear after the base branch merges to master. |
smallinsky
approved these changes
May 6, 2024
Tener
approved these changes
May 6, 2024
f0a4cbc to
f58c976
Compare
1dec6b0 to
b9a8ae4
Compare
b9a8ae4 to
4339bc9
Compare
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
May 27, 2024
* add spanner to tsh and teleterm * handle spanner events in web ui * update web audit events test snapshot * customize web ui connect for spanner * update ConnectDialog snapshot
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was extracted from and builds on the spanner engine PR:
It adds tsh support and web ui audit event support.
Will be rebased automatically onto master after the engine PR merges.
A docs update will be coming in the next PR.