Skip to content

support gcloud spanner in tsh and web UI#41129

Merged
GavinFrazar merged 5 commits intomasterfrom
gavinfrazar/gcloud-spanner-clients
May 7, 2024
Merged

support gcloud spanner in tsh and web UI#41129
GavinFrazar merged 5 commits intomasterfrom
gavinfrazar/gcloud-spanner-clients

Conversation

@GavinFrazar
Copy link
Copy Markdown
Contributor

This was extracted from and builds on the spanner engine PR:

It adds tsh support and web ui audit event support.

Will be rebased automatically onto master after the engine PR merges.

A docs update will be coming in the next PR.

@GavinFrazar GavinFrazar added database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 2, 2024
@github-actions github-actions Bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ui labels May 2, 2024
@github-actions github-actions Bot requested review from gzdunek and ryanclark May 2, 2024 06:04
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/gcloud-spanner branch from ea5e499 to f0a4cbc Compare May 2, 2024 21:04
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/gcloud-spanner-clients branch from d907342 to f5b578b Compare May 2, 2024 21:09
Comment thread web/packages/teleport/src/services/audit/makeEvent.ts Outdated
Comment thread tool/tsh/common/proxy.go Outdated
@GavinFrazar
Copy link
Copy Markdown
Contributor Author

I think the "buf breaking" lint error is just because this PR is currently based on my other feature branch instead of master, and since I force-pushed that branch it thinks there's been a buf breaking change. It should clear after the base branch merges to master.

@GavinFrazar GavinFrazar force-pushed the gavinfrazar/gcloud-spanner branch from f0a4cbc to f58c976 Compare May 7, 2024 20:39
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/gcloud-spanner-clients branch from 1dec6b0 to b9a8ae4 Compare May 7, 2024 22:27
Base automatically changed from gavinfrazar/gcloud-spanner to master May 7, 2024 22:39
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/gcloud-spanner-clients branch from b9a8ae4 to 4339bc9 Compare May 7, 2024 22:49
@GavinFrazar GavinFrazar enabled auto-merge May 7, 2024 23:07
@GavinFrazar GavinFrazar added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit ed7d0d2 May 7, 2024
@GavinFrazar GavinFrazar deleted the gavinfrazar/gcloud-spanner-clients branch May 7, 2024 23:34
@public-teleport-github-review-bot
Copy link
Copy Markdown

@GavinFrazar See the table below for backport results.

Branch Result
branch/v15 Failed

GavinFrazar added a commit that referenced this pull request May 27, 2024
* add spanner to tsh and teleterm

* handle spanner events in web ui

* update web audit events test snapshot

* customize web ui connect for spanner

* update ConnectDialog snapshot
github-merge-queue Bot pushed a commit that referenced this pull request May 29, 2024
* add GCP Spanner (#40859)

* support gcloud spanner in tsh and web UI (#41129)

* add spanner to tsh and teleterm

* handle spanner events in web ui

* update web audit events test snapshot

* customize web ui connect for spanner

* update ConnectDialog snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants